Skip to content

readme: networking should be part of masterConfiguration #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nirmoy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

readme: networking should be part of masterConfiguration #97

nirmoy wants to merge 2 commits into from

Conversation

@nirmoy
Copy link

@nirmoy nirmoy commented Mar 5, 2019

There is no networking field outside of masterConfiguration

@dlipovetsky dlipovetsky self-requested a review May 3, 2019 00:16
dlipovetsky
dlipovetsky approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry about the late review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dlipovetsky dlipovetsky dlipovetsky approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nirmoy @dlipovetsky @vannrt